[ 
https://issues.apache.org/jira/browse/BEAM-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818811#comment-15818811
 ] 

Luke Cwik commented on BEAM-849:
--------------------------------

Yes, I agree that for unbounded pipelines `waitUntilFinish` seems to be 
confusing and is unlikely to be called. An unbounded pipeline is never expected 
to finish (could stop if it got into an unrecoverable error state) so 
`waitUntilFinish(Duration)` could be block for Duration and unless the pipeline 
failed, throw an exception if in a non terminal status (like discussed above 
for bounded pipelines).

I don't think `waitUntilFinish` is meant to modify the execution of the 
pipeline and is only meant to block and check for terminal pipeline state.

> Redesign PipelineResult API
> ---------------------------
>
>                 Key: BEAM-849
>                 URL: https://issues.apache.org/jira/browse/BEAM-849
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Pei He
>
> Current state: 
> Jira https://issues.apache.org/jira/browse/BEAM-443 addresses 
> waitUntilFinish() and cancel(). 
> However, there are additional work around PipelineResult: 
> need clearly defined contract and verification across all runners 
> need to revisit how to handle metrics/aggregators 
> need to be able to get logs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to