[
https://issues.apache.org/jira/browse/BEAM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813835#comment-15813835
]
ASF GitHub Bot commented on BEAM-1248:
--------------------------------------
GitHub user vectorijk opened a pull request:
https://github.com/apache/beam/pull/1755
[BEAM-1248] Combine with side inputs API should match ParDo
add Combine withSideInputs API with varargs version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vectorijk/beam BEAM-1248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1755
----
commit 8768c576a62d1a17cdc60182cfda20513da362d2
Author: Kai Jiang <[email protected]>
Date: 2017-01-10T00:40:06Z
BEAM-1248 Combine with side inputs API should match ParDo
match Combine withSideInputs API with varargs version
----
> Combine with side inputs API should match ParDo
> -----------------------------------------------
>
> Key: BEAM-1248
> URL: https://issues.apache.org/jira/browse/BEAM-1248
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Minor
> Labels: easy, starter
>
> From user@beam, the methods for adding side inputs to a Combine transform do
> not fully match those for adding side inputs to ParDo.
> "ParDo has the .withSideInputs(Iterable<PCollectionView<...>>) version but
> also a varargs version withSideInputs(PCollectionView<?>...) but Combine only
> has the Iterable version."
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
