[ 
https://issues.apache.org/jira/browse/BEAM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815529#comment-15815529
 ] 

ASF GitHub Bot commented on BEAM-1248:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1755


> Combine with side inputs API should match ParDo
> -----------------------------------------------
>
>                 Key: BEAM-1248
>                 URL: https://issues.apache.org/jira/browse/BEAM-1248
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Minor
>              Labels: easy, starter
>
> From user@beam, the methods for adding side inputs to a Combine transform do 
> not fully match those for adding side inputs to ParDo.
> "ParDo has the .withSideInputs(Iterable<PCollectionView<...>>) version but 
> also a varargs version withSideInputs(PCollectionView<?>...) but Combine only 
> has the Iterable version."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to