[
https://issues.apache.org/jira/browse/BEAM-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830876#comment-15830876
]
ASF GitHub Bot commented on BEAM-759:
-------------------------------------
GitHub user aaltay opened a pull request:
https://github.com/apache/beam/pull/1802
[BEAM-759] Make TestPipeline.run fail when the underlying execution fails.
Also, DataflowRunner will log the last error from its wait_until_finish
method.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aaltay/incubator-beam expand
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1802
----
commit 4313d50b49c51da328ef5b6de6be33ba73e03150
Author: Ahmet Altay <[email protected]>
Date: 2017-01-20T00:13:07Z
Make TestPipeline.run fail when the underlying execution fails.
Also, DataflowRunner will log the last error from its wait_until_finish
method.
----
> PipelineResult needs waitToFinish() and cancel()
> ------------------------------------------------
>
> Key: BEAM-759
> URL: https://issues.apache.org/jira/browse/BEAM-759
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Ahmet Altay
> Priority: Minor
> Labels: sdk-consistency
>
> Java SDK, added waitToFinish() and cancel() to the PipelineResults, and as a
> result were able to remove BlockingDataflowRunner.
> (See: https://issues.apache.org/jira/browse/BEAM-443)
> The same changes needs to happen in python sdk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
