[ 
https://issues.apache.org/jira/browse/BEAM-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930246#comment-15930246
 ] 

Thomas Groh commented on BEAM-1718:
-----------------------------------

This is a Documentation/Implementation mismatch. I think that with the 
existence of {{getAllowedTimestampSkew}} it's fine to have the skew go up to 
infinity; simultaneously, I believe {{getAllowedTimestampSkew}} to have 
significant problems and should be strongly discouraged.

> Returning Duration.millis(Long.MAX_VALUE) in DoFn.getAllowedTimestampSkew() 
> causes Overflow/Underflow
> -----------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-1718
>                 URL: https://issues.apache.org/jira/browse/BEAM-1718
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 0.5.0
>            Reporter: Tobias Feldhaus
>            Assignee: Thomas Groh
>
> Overriding getAllowedTimestampSkew() in DoFn and returning 
> Duration.millis(Long.MAX_VALUE) (as suggested in the JavaDoc for allowing 
> infinite skew) causes an Overflow/Underflow



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to