[
https://issues.apache.org/jira/browse/BEAM-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938506#comment-15938506
]
Aljoscha Krettek commented on BEAM-576:
---------------------------------------
But we still need to set a GC timer? Otherwise we might never revisit a window
and check whether it should be GC'ed.
> ReduceFnRunner should GC based on current WM, not on a fired Timer
> ------------------------------------------------------------------
>
> Key: BEAM-576
> URL: https://issues.apache.org/jira/browse/BEAM-576
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Priority: Minor
>
> ReduceFnRunner currently uses the time of a timer to determine if it is the
> garbage collection timer. Instead, it should examine the time a window is
> expired and the current input watermark to determine if the window should be
> Garbage Collected. It should additionally. ignore all timers for windows that
> have already been expired.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
