[
https://issues.apache.org/jira/browse/BEAM-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939360#comment-15939360
]
Kenneth Knowles commented on BEAM-576:
--------------------------------------
It is up to the runner how manage GC. At some point the window becomes eligible
for GC and at some point later the runner should flush and GC it. A goofy
strawman would be a runner that just always has some polling involved so you
don't need an explicit timer to wake up and check for GC. You could also just
choose to set fewer timers than you have windows, if they were a burden.
I'm willing to say that a runner is broken if a non-infinite window fails to
flush, so it rules out runners that just ignore the issue. I don't care if they
actually release resources, but I do want the data to be emitted :-)
> ReduceFnRunner should GC based on current WM, not on a fired Timer
> ------------------------------------------------------------------
>
> Key: BEAM-576
> URL: https://issues.apache.org/jira/browse/BEAM-576
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Priority: Minor
>
> ReduceFnRunner currently uses the time of a timer to determine if it is the
> garbage collection timer. Instead, it should examine the time a window is
> expired and the current input watermark to determine if the window should be
> Garbage Collected. It should additionally ignore all timers for windows that
> have already been expired.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
