[
https://issues.apache.org/jira/browse/BEAM-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983904#comment-15983904
]
ASF GitHub Bot commented on BEAM-2021:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2691
[BEAM-2021] Add getElementCoders to UnionCoder
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is an explicit method on UnionCoder that is completely unrelated to
the serialization and deserialization of the Coder.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam element_coders_union_coder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2691.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2691
----
commit abd5dd91ec8dc3a5f093638b67c74952a242f786
Author: Thomas Groh <[email protected]>
Date: 2017-04-26T00:39:38Z
Add getElementCoders to UnionCoder
This is an explicit method on UnionCoder that is completely unrelated to
the serialization and deserialization of the Coder.
----
> Fix Java's Coder class hierarchy
> --------------------------------
>
> Key: BEAM-2021
> URL: https://issues.apache.org/jira/browse/BEAM-2021
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-runner-api, sdk-java-core
> Affects Versions: First stable release
> Reporter: Kenneth Knowles
> Assignee: Thomas Groh
> Fix For: First stable release
>
>
> This is thoroughly out of hand. In the runner API world, there are two paths:
> 1. URN plus component coders plus custom payload (in the form of component
> coders alongside an SdkFunctionSpec)
> 2. Custom coder (a single URN) and payload is serialized Java. I think this
> never has component coders.
> The other base classes have now been shown to be extraneous: they favor
> saving ~3 lines of boilerplate for rarely written code at the cost of
> readability. Instead they should just be dropped.
> The custom payload is an Any proto in the runner API. But tying the Coder
> interface to proto would be unfortunate from a design perspective and cannot
> be done anyhow due to dependency hell.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
