[
https://issues.apache.org/jira/browse/BEAM-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985748#comment-15985748
]
ASF GitHub Bot commented on BEAM-2021:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2720
[BEAM-2021] Rename StandardCoder to StructuredCoder
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
StandardCoder has improper connotations - mainly, "Standard" as in
"Standardized" as opposed to "Standard" as in "normal". StructuredCoder
communicates the important part of the class, which is that the coder
has some meaningful structure, and that structure can be used by a
runner.
Keep StandardCoder around as a temporary shim for the DataflowRunner.
Will be removed as soon as an updated worker is available.
To be merged after https://github.com/apache/beam/pull/2717
R: @kennknowles or @lukecwik
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam structured_coder_not_standard_coder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2720
----
commit 8c6a31dc66e003616b681e9685aa7cd26091d064
Author: Thomas Groh <[email protected]>
Date: 2017-04-26T22:12:54Z
Remove Coder Encoding IDs
These were never safe to use, and will not be used once Coders have been
migrated to the Runner API representation.
commit 2d61d90be3391dc8bbec42d54c63f22538d49387
Author: Thomas Groh <[email protected]>
Date: 2017-04-26T23:30:57Z
Rename StandardCoder to StructuredCoder
StandardCoder has improper connotations - mainly, "Standard" as in
"Standardized" as opposed to "Standard" as in "normal". StructuredCoder
communicates the important part of the class, which is that the coder
has some meaningful structure, and that structure can be used by a
runner.
----
> Fix Java's Coder class hierarchy
> --------------------------------
>
> Key: BEAM-2021
> URL: https://issues.apache.org/jira/browse/BEAM-2021
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-runner-api, sdk-java-core
> Affects Versions: First stable release
> Reporter: Kenneth Knowles
> Assignee: Thomas Groh
> Fix For: First stable release
>
>
> This is thoroughly out of hand. In the runner API world, there are two paths:
> 1. URN plus component coders plus custom payload (in the form of component
> coders alongside an SdkFunctionSpec)
> 2. Custom coder (a single URN) and payload is serialized Java. I think this
> never has component coders.
> The other base classes have now been shown to be extraneous: they favor
> saving ~3 lines of boilerplate for rarely written code at the cost of
> readability. Instead they should just be dropped.
> The custom payload is an Any proto in the runner API. But tying the Coder
> interface to proto would be unfortunate from a design perspective and cannot
> be done anyhow due to dependency hell.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
