[
https://issues.apache.org/jira/browse/BEAM-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986046#comment-15986046
]
ASF GitHub Bot commented on BEAM-2086:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2731
[BEAM-2086] Remove TestDataflowRunner reliance on metrics in streaming
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
Metrics are not supported yet in Dataflow streaming.
- The Dataflow service automatically shuts down jobs when their input
watermarks reach infinity, so we don't need metrics for that.
- Counting `PAsserts` is nice but given the current architecture less of a
critical concern. And anyhow, Dataflow just doesn't support it yet!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam TestDataflowRunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2731
----
commit 4757d54bbd372b76ca44680a7b7886819db9943f
Author: Kenneth Knowles <[email protected]>
Date: 2017-04-27T00:55:29Z
Do not rely on metrics in streaming TestDataflowRunner
The Dataflow service automatically shuts down jobs when their
input watermarks reach infinity, and other functionality can be
restored when the feature is restored to the Dataflow service.
----
> TestDataflowRunner relies on metrics which are not present in streaming jobs
> ----------------------------------------------------------------------------
>
> Key: BEAM-2086
> URL: https://issues.apache.org/jira/browse/BEAM-2086
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
>
> Currently, we are lacking the metrics by which the TestDataflowRunner
> determines that a job is complete and that all PAsserts ran.
> We do not need to use the watermark metrics - the service handles shutdown
> now.
> We should aim to restore PAssert counting, though the new PAssert
> architecture (both that already implemented as well as future plans)
> significantly mitigate the risk.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
