[ 
https://issues.apache.org/jira/browse/BEAM-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986857#comment-15986857
 ] 

ASF GitHub Bot commented on BEAM-2086:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2731


> TestDataflowRunner relies on metrics which are not present in streaming jobs
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-2086
>                 URL: https://issues.apache.org/jira/browse/BEAM-2086
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Blocker
>
> Currently, we are lacking the metrics by which the TestDataflowRunner 
> determines that a job is complete and that all PAsserts ran.
> We do not need to use the watermark metrics - the service handles shutdown 
> now.
> We should aim to restore PAssert counting, though the new PAssert 
> architecture (both that already implemented as well as future plans) 
> significantly mitigate the risk.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to