[
https://issues.apache.org/jira/browse/BEAM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986900#comment-15986900
]
ASF GitHub Bot commented on BEAM-1327:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2741
[BEAM-1327] Rollforwards "Replace OutputTimeFn UDF with TimestampCombiner
enum""
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This reverts commit 83d41fcce0c7b123459e5d26ab9938de49f48dab,
which reverted commit f38e4271334fced94e8dc1dc97f47b60fa810586
It will need a new worker, as so many pending PRs will.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam OutputTimeFn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2741.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2741
----
commit 5b014db1fd5ee53aee2bd4e78ee4584ea820f5a2
Author: Kenneth Knowles <[email protected]>
Date: 2017-04-27T15:56:52Z
Rollforwards "Replace OutputTimeFn UDF with TimestampCombiner enum""
This reverts commit 83d41fcce0c7b123459e5d26ab9938de49f48dab,
which reverted commit f38e4271334fced94e8dc1dc97f47b60fa810586
----
> Replace OutputTimeFn with enum
> ------------------------------
>
> Key: BEAM-1327
> URL: https://issues.apache.org/jira/browse/BEAM-1327
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only
> three sensible values known: MIN, MAX, EOW. The interface is right for
> implementing these, but the full class is left over from the days when there
> was little cost to shipping new kinds of fns. An enum is concise.
> This can be done "mostly" backwards compatibly with legacy adapters in place,
> but might be less confusing without them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
