[
https://issues.apache.org/jira/browse/BEAM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993689#comment-15993689
]
Kenneth Knowles commented on BEAM-1327:
---------------------------------------
Also, the choice to not call it {{OutputTimeFn}} comes from its reduced scope -
it has simple well-defined semantics for combining timestamps in a variety of
possible situations. Previously it seems fixed only to the output of GBK. I'm
somewhat ambivalent on this. Mostly I want to choose a name we don't have to
change again. The Runner API should then adopt that name.
> Replace OutputTimeFn with enum
> ------------------------------
>
> Key: BEAM-1327
> URL: https://issues.apache.org/jira/browse/BEAM-1327
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only
> three sensible values known: MIN, MAX, EOW. The interface is right for
> implementing these, but the full class is left over from the days when there
> was little cost to shipping new kinds of fns. An enum is concise.
> This can be done "mostly" backwards compatibly with legacy adapters in place,
> but might be less confusing without them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
