[
https://issues.apache.org/jira/browse/BEAM-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990101#comment-15990101
]
Ted Yu commented on BEAM-1773:
------------------------------
w.r.t. ValidationException, I assume you mean creating ValidationException
class (subclass of IOException) which is declared by the relevant methods.
w.r.t. InterruptedException, allow me to refer to
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
which has the following:
{code}
} catch (InterruptedException e) {
throw (IOException)new InterruptedIOException("Interrupted: action="
+ action + ", retry policy=" + connectionRetryPolicy).initCause(e);
}
{code}
> Consider allowing Source#validate() to throw exception
> ------------------------------------------------------
>
> Key: BEAM-1773
> URL: https://issues.apache.org/jira/browse/BEAM-1773
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: beam-1773.v1.patch, beam-1773.v2.patch
>
>
> In HDFSFileSource.java :
> {code}
> @Override
> public void validate() {
> ...
> } catch (IOException | InterruptedException e) {
> throw new RuntimeException(e);
> }
> {code}
> Source#validate() should be allowed to throw exception so that we don't
> resort to using RuntimeException.
> Here was related thread on mailing list:
> http://search-hadoop.com/m/Beam/gfKHFOwE0uETxae?subj=Re+why+Source+validate+is+not+declared+to+throw+any+exception
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
