[
https://issues.apache.org/jira/browse/BEAM-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991667#comment-15991667
]
ASF GitHub Bot commented on BEAM-1773:
--------------------------------------
GitHub user tedyu opened a pull request:
https://github.com/apache/beam/pull/2809
BEAM-1773 Consider allowing Source#validate() to throw exception
See if this approach looks good.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/beam master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2809.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2809
----
commit e9e50e5af3934b7590df0e7c1571153d56ee9031
Author: tedyu <[email protected]>
Date: 2017-05-01T22:21:07Z
BEAM-1773 Consider allowing Source#validate() to throw exception
----
> Consider allowing Source#validate() to throw exception
> ------------------------------------------------------
>
> Key: BEAM-1773
> URL: https://issues.apache.org/jira/browse/BEAM-1773
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 1773.v4.patch, beam-1773.v1.patch, beam-1773.v2.patch
>
>
> In HDFSFileSource.java :
> {code}
> @Override
> public void validate() {
> ...
> } catch (IOException | InterruptedException e) {
> throw new RuntimeException(e);
> }
> {code}
> Source#validate() should be allowed to throw exception so that we don't
> resort to using RuntimeException.
> Here was related thread on mailing list:
> http://search-hadoop.com/m/Beam/gfKHFOwE0uETxae?subj=Re+why+Source+validate+is+not+declared+to+throw+any+exception
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
