[
https://issues.apache.org/jira/browse/BEAM-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993572#comment-15993572
]
ASF GitHub Bot commented on BEAM-1340:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2840
[BEAM-1340,BEAM-1345] Move user-facing timer-related classes out of util
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is build on top of #2833. Timers are actually mostly orthogonal to
state, but a user is generally going to use them together. I didn't want to
clutter with namespaces so I put them in `state`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam move-Timers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2840
----
commit 8144c877ef58eadcdca486370055fb96ef734ce3
Author: Kenneth Knowles <[email protected]>
Date: 2017-04-21T03:46:37Z
Simplify type parameters of StateSpec and related
Before this change, almost all uses of state had a type variable that
existing only to support the esoteric use of a KeyedCombineFn in
a state cell. KeyedCombineFn is now gone, so the key is no longer
required.
commit 50667f2af89f4c43a7e0e8b29ca87407af331110
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-02T17:29:33Z
Move Java sdk.util.state to sdk.state
commit e1b88db22b72d1bed0a039125e059a355723207d
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-02T17:41:01Z
Add @Internal and @Experimental to state package
commit 24141d70e264c28dca1432195bd912c9814da283
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-02T19:28:39Z
Move user-facing timer-related classes out of util
commit 615b8d5c260cc176dce1f9be0a9790f2eeeeaf02
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-02T19:31:02Z
Mark TimeDomain experimental alongside Timers; improve javadoc
----
> Remove or make private public bits of the SDK that shouldn't be public
> ----------------------------------------------------------------------
>
> Key: BEAM-1340
> URL: https://issues.apache.org/jira/browse/BEAM-1340
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-java-extensions
> Reporter: Kenneth Knowles
> Priority: Blocker
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> This JIRA is for the many small changes that do not merit their own JIRA
> towards getting the SDK's API surface right. For example, removal of
> `DoFn.InputProvider` and `DoFn.OutputReceiver`.
> While the above is not quite backwards incompatible, succeeding at this task
> surely will be.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
