[ 
https://issues.apache.org/jira/browse/BEAM-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996695#comment-15996695
 ] 

ASF GitHub Bot commented on BEAM-1340:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2891

    [BEAM-1340,BEAM-1345] Vital moves of user-facing stuff out of util

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam vital-moves

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2891
    
----
commit 20e30905bf08b6ac5fea7f99fc1eeb354b9c623e
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-02T17:29:33Z

    Move Java sdk.util.state to sdk.state

commit 6068655f23ac129b60dfa3f7719f8f8a4fdbacec
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-02T17:41:01Z

    Add @Internal and @Experimental to state package

commit f2a2c1f7e1639955a5823b0351f6047019c6a14b
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-02T19:31:02Z

    Mark TimeDomain experimental alongside Timers; improve javadoc

commit 0ea750a1344fb1e7c11aaace2fd267d6e5691af3
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-02T19:46:46Z

    Move user-facing timer-related classes out of util

commit 5765217933b58f4019e4dca99e3a4a48cd38d122
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-02T19:53:26Z

    Move WindowingStrategy from util to values
    
    WindowingStrategy is a property on PCollection that transform authors
    regularly mess with. It is part of the public API.

commit 498ca8dbd4c0d9f91913e74fe74675c235dd96d7
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-04T02:36:45Z

    Move PathValidator adjacent to other filesystem bits

commit e5574feb473cef82d9a2871d697e37398035f076
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-04T02:46:59Z

    Move SideInputReader to runners/core-java

commit 668acc5cf67fe26dd68dd18474759c6cc5faaa7e
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-04T02:57:02Z

    Move Reshuffle and ReshuffleTrigger out of util
    
    These are two deprecated, but regularly used, transforms and triggers, to 
the
    point where the Runner API proto even includes something akin to the
    ReshuffleTrigger.
    
    They are moved to where they "belong" and marked deprecated.

commit e8dd75aa9628b1ef813ffde08894fcb86249736a
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-04T03:19:51Z

    Move ValueWithRecordId to sdk.values, annotated

commit 1cef2e4d3e09971a40cb89c6c5fc8295b3cbeb07
Author: Kenneth Knowles <k...@google.com>
Date:   2017-05-04T03:34:54Z

    Move some PCollectionView bits out of util

----


> Remove or make private public bits of the SDK that shouldn't be public
> ----------------------------------------------------------------------
>
>                 Key: BEAM-1340
>                 URL: https://issues.apache.org/jira/browse/BEAM-1340
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core, sdk-java-extensions
>            Reporter: Kenneth Knowles
>            Priority: Blocker
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>
> This JIRA is for the many small changes that do not merit their own JIRA 
> towards getting the SDK's API surface right. For example, removal of 
> `DoFn.InputProvider` and `DoFn.OutputReceiver`.
> While the above is not quite backwards incompatible, succeeding at this task 
> surely will be.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to