[
https://issues.apache.org/jira/browse/BEAM-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999410#comment-15999410
]
ASF GitHub Bot commented on BEAM-1340:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2939
[BEAM-1340] Move Dataflow PipelineOptions to Dataflow package
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @davorbonaci
I believe the cost/benefit of this change make it worth consideration for
including in the first stable release.
This takes the `runners.dataflow.options` package and moves it to the
`runners.dataflow` package. This is a fully automated refactor (thanks,
IntelliJ!). The first commit is just the refactor, for easy review. The second
commit fixes imports automatically.
This will allow the options - particularly the factories for their
defaults, such as the default file stager - to use package-private features of
the runner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam Dataflow-PipelineOptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2939.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2939
----
commit 8f9712f9826c97b73e28a3776aca5d305d929bd5
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-06T11:56:58Z
Move Dataflow PipelineOptions to Dataflow package
commit aab23bd8667cb514c4986f5c7aaaa29d3d91b484
Author: Kenneth Knowles <[email protected]>
Date: 2017-05-06T12:07:06Z
fixup! Fix imports
----
> Remove or make private public bits of the SDK that shouldn't be public
> ----------------------------------------------------------------------
>
> Key: BEAM-1340
> URL: https://issues.apache.org/jira/browse/BEAM-1340
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-java-extensions
> Reporter: Kenneth Knowles
> Priority: Blocker
> Labels: backward-incompatible
> Fix For: 2.0.0
>
>
> This JIRA is for the many small changes that do not merit their own JIRA
> towards getting the SDK's API surface right. For example, removal of
> `DoFn.InputProvider` and `DoFn.OutputReceiver`.
> While the above is not quite backwards incompatible, succeeding at this task
> surely will be.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
