[
https://issues.apache.org/jira/browse/BEAM-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011368#comment-16011368
]
ASF GitHub Bot commented on BEAM-2252:
--------------------------------------
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/3152
[BEAM-2252] Use pluginManagement instead of redefining maven-shade-plugin
to inherit build order from root pom.xml
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`.
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam beam2252
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3152
----
commit ca62f3311d6a622ce3895a716da97187bbd0709a
Author: Luke Cwik <[email protected]>
Date: 2017-05-15T20:39:12Z
[BEAM-2252] Use pluginManagement instead of redefining maven-shade-plugin
to inherit build order from root pom.xml
----
> maven-shade-plugin should be defined in pluginManagement instead of plugins
> so that the plugin execution order defined by the root pom.xml is used
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-2252
> URL: https://issues.apache.org/jira/browse/BEAM-2252
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow, runner-direct, sdk-java-core,
> sdk-java-gcp
> Affects Versions: 2.1.0
> Reporter: Luke Cwik
> Priority: Minor
> Labels: newbie, starter
>
> Several of our child pom.xml declare maven-shade-plugin within build/plugins
> instead of build/pluginManagement which affects the plugin execution order.
> See BEAM-2242 for when we surgically fixed how shading was performed and this
> issue is about revisiting that change and improving upon it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
