[ 
https://issues.apache.org/jira/browse/BEAM-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017733#comment-16017733
 ] 

ASF GitHub Bot commented on BEAM-2252:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3152


> maven-shade-plugin should be defined in pluginManagement instead of plugins 
> so that the plugin execution order defined by the root pom.xml is used
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2252
>                 URL: https://issues.apache.org/jira/browse/BEAM-2252
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow, runner-direct, sdk-java-core, 
> sdk-java-gcp
>    Affects Versions: 2.1.0
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Minor
>              Labels: newbie, starter
>
> Several of our child pom.xml declare maven-shade-plugin within build/plugins 
> instead of build/pluginManagement which affects the plugin execution order.
> See BEAM-2242 for when we surgically fixed how shading was performed and this 
> issue is about revisiting that change and improving upon it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to