[
https://issues.apache.org/jira/browse/BEAM-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Kirpichov updated BEAM-2483:
-----------------------------------
Description:
https://github.com/apache/beam/pull/1898 adds Splittable DoFn to Dataflow
runner, however only in streaming mode.
Because of this, to get ValidatesRunner test coverage, the PR makes
SplittableDoFnTest explicitly setStreaming(true) - because there's currently no
ValidatesRunner execution for Dataflow in streaming mode. That's tracked in
https://issues.apache.org/jira/browse/BEAM-1620, and once that JIRA is closed,
we should use that to simply skip SplittableDoFnTest in the batch execution,
but not skip it in the streaming execution (e.g. by having a category for
"streaming-only" tests and marking it with that category).
CC: [~kenn]
was:
https://github.com/apache/beam/pull/1898 adds Splittable DoFn to Dataflow
runner, however only in streaming mode.
Because of this, to get ValidatesRunner test coverage, the PR makes
SplittableDoFnTest explicitly setStreaming(true) - because there's currently no
ValidatesRunner execution for Dataflow in streaming mode. That's tracked in
https://issues.apache.org/jira/browse/BEAM-1620, and once that JIRA is closed,
we should use that to simply skip SplittableDoFnTest in the batch execution,
but not skip it in the streaming execution.
CC: [~kenn]
> SplittableDoFnTest should not explicitly setStreaming(true)
> -----------------------------------------------------------
>
> Key: BEAM-2483
> URL: https://issues.apache.org/jira/browse/BEAM-2483
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
>
> https://github.com/apache/beam/pull/1898 adds Splittable DoFn to Dataflow
> runner, however only in streaming mode.
> Because of this, to get ValidatesRunner test coverage, the PR makes
> SplittableDoFnTest explicitly setStreaming(true) - because there's currently
> no ValidatesRunner execution for Dataflow in streaming mode. That's tracked
> in https://issues.apache.org/jira/browse/BEAM-1620, and once that JIRA is
> closed, we should use that to simply skip SplittableDoFnTest in the batch
> execution, but not skip it in the streaming execution (e.g. by having a
> category for "streaming-only" tests and marking it with that category).
> CC: [~kenn]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
