[
https://issues.apache.org/jira/browse/BEAM-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059922#comment-16059922
]
ASF GitHub Bot commented on BEAM-2502:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3425
[BEAM-2502, BEAM-2504, BEAM-2505] Fix processing time timer handling in
ReduceFnRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`.
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
A few major correctness issues.
R: @bjchambers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam ReduceFnRunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3425
----
commit 5773f4e3926054b463d37dff5109d66150739487
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T18:31:28Z
Add window matcher for pane info
commit 16863f1ae0fc89a47adece6afc56baf1405cca91
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T18:56:53Z
Tidy LateDataDroppingDoFnRunner
commit 51328352043a26bb55e754671b357324dbd9a20d
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T19:52:42Z
ReduceFnTester can advance clocks without firing timers
commit f0f1d13d799372a2b65b18663a505ee6488a01da
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T19:53:15Z
ReduceFnTester assertion for windows that have data buffered
commit eb3fb2347bc57946a925b62b32780c036efee62f
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T19:56:14Z
Drop late data in ReduceFnTester
commit 4856f88e99a6e7dac40e6dd34c0b2d27563e7759
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T19:56:34Z
Do not GC windows based on processing time timer!
commit 470e7f8a18717f09e2c0e8e2b291fb3298333db7
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T20:04:23Z
Add test reproducing BEAM-2505, ignored
commit 85e583d87a8be4e16eab3dca5fc87d5259b8b0ab
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-22T20:05:42Z
Add tests for corner cases of processing time timers
----
> Processing time timers for expired windows are not ignored
> ----------------------------------------------------------
>
> Key: BEAM-2502
> URL: https://issues.apache.org/jira/browse/BEAM-2502
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Critical
> Fix For: 2.1.0
>
>
> If the ReduceFnRunner receives a processing time timer for an expired window,
> it may produce output even though the window is expired (and may have already
> sent a final output!)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
