[
https://issues.apache.org/jira/browse/BEAM-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060275#comment-16060275
]
ASF GitHub Bot commented on BEAM-2502:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3429
[BEAM-2502] Ignore processing time timers in expired windows
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`.
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
Technically, the test added here is OK to fail - it is a race condition
anyhow whether GC clears the state or the processing time timer "makes it in
time". But for consistency, I think expired windows should not incur further
processing.
R: @bjchambers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam ReduceFnRunner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3429
----
commit 9f9ec3d40687e862daaff55a668e5c006de5af2c
Author: Kenneth Knowles <[email protected]>
Date: 2017-06-23T01:09:11Z
Ignore processing time timers in expired windows
----
> Processing time timers for expired windows are not ignored
> ----------------------------------------------------------
>
> Key: BEAM-2502
> URL: https://issues.apache.org/jira/browse/BEAM-2502
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
> Fix For: 2.1.0
>
>
> If the ReduceFnRunner receives a processing time timer for an expired window,
> it may produce output even though the window is expired (and may have already
> sent a final output!)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
