[
https://issues.apache.org/jira/browse/BEAM-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078589#comment-16078589
]
Kenneth Knowles commented on BEAM-2571:
---------------------------------------
[~aljoscha] any idea why the linked PR would cause a problem for
CombineWithContext with side inputs in streaming for the FlinkRunner?
At a high level the changes are:
1. drop late processing time timers
2. when trigger/ReduceFnRunner timers arrive together, don't look at the timers
themselves but just activate the window (this is finally making it match
https://s.apache.org/beam-triggers and https://s.apache.org/beam-lateness)
> Flink ValidatesRunner failing CombineTest.testSlidingWindowsCombineWithContext
> ------------------------------------------------------------------------------
>
> Key: BEAM-2571
> URL: https://issues.apache.org/jira/browse/BEAM-2571
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Fix For: 2.1.0
>
>
> This appears to have been caused by https://github.com/apache/beam/pull/3429
> which fixes a couple errors in how trigger timers were processed / final
> panes labeled.
> I am investigating, considering roll back vs forward fix. Since it is an
> esoteric use case where I would advise users to use a stateful DoFn instead,
> I think the bug fixed probably outweighs the bug introduced. I would like to
> fix for 2.1.0 but will report back soon.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
