[
https://issues.apache.org/jira/browse/BEAM-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083848#comment-16083848
]
Aljoscha Krettek commented on BEAM-2571:
----------------------------------------
I think it turns out that the fix for this is to change this line:
https://github.com/apache/beam/blob/e8f26085e889f8f618c0961a5458cbc42b432c01/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java#L475-L475
to
{code}
timerService.advanceWatermark(actualInputWatermark - 1);
{code}
I think there could be some other issues, though, and I also want to make sure
to add some tests around the watermark contract and how the Flink Operator
observes it.
> Flink ValidatesRunner failing CombineTest.testSlidingWindowsCombineWithContext
> ------------------------------------------------------------------------------
>
> Key: BEAM-2571
> URL: https://issues.apache.org/jira/browse/BEAM-2571
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Aljoscha Krettek
> Fix For: 2.1.0
>
>
> This appears to have been caused by https://github.com/apache/beam/pull/3429
> which fixes a couple errors in how trigger timers were processed / final
> panes labeled.
> I am investigating, considering roll back vs forward fix. Since it is an
> esoteric use case where I would advise users to use a stateful DoFn instead,
> I think the bug fixed probably outweighs the bug introduced. I would like to
> fix for 2.1.0 but will report back soon.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
