James Xu commented on BEAM-2747:

[~mingmxu] I think the Adapter strategy should work.

Although AggregateFunctionImpl.create() only take one Class parameter. But we 
can copy the implementation out, make some modification, make it accept a 
CombineFn instance.

> accept CombineFn as UDAF
> ------------------------
>                 Key: BEAM-2747
>                 URL: https://issues.apache.org/jira/browse/BEAM-2747
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>              Labels: dsl_sql_merge, dsl_sql_review
> refer to 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhgo

This message was sent by Atlassian JIRA

Reply via email to