[
https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121681#comment-16121681
]
James Xu commented on BEAM-2747:
--------------------------------
To be more clear, since the signature to add a function is:
```
void add(String var1, Function var2);
```
we can create a `BeamAggregateFunctiomImpl` which copy the implementation of
Calcite's `AggregationFunctionImpl`, but add a method which accept a CombineFn
to build a BeamAggregateFunctiomImpl.
> accept CombineFn as UDAF
> ------------------------
>
> Key: BEAM-2747
> URL: https://issues.apache.org/jira/browse/BEAM-2747
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Labels: dsl_sql_merge, dsl_sql_review
>
> refer to
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhgo
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
