[
https://issues.apache.org/jira/browse/BEAM-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146568#comment-16146568
]
Aviem Zur commented on BEAM-1763:
---------------------------------
Currently, {{TestPipeline}} does the validation using the success counter
metric once the pipeline running has finished.
https://github.com/apache/beam/blob/v2.1.0/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java#L341
https://github.com/apache/beam/blob/v2.1.0/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java#L505-L532
> TestPipeline should ensure that all assertions succeeded
> --------------------------------------------------------
>
> Key: BEAM-1763
> URL: https://issues.apache.org/jira/browse/BEAM-1763
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Aviem Zur
> Fix For: 2.0.0
>
>
> This doesn't need to be part of each {{PipelineRunner}} implementation if it
> goes through the {{PipelineResult}} APIs. The assertion can be of the form
> that if the Pipeline is finished, then the number of successful assertions is
> equal to the total number of assertions.
> Suggested solution:
> For runners which support metrics, use the counters for successful/failed
> assertions and compare them to expected number of assertions.
> Runners which do not support metrics should either implement metrics or
> override {{PAssert}} in a way that verifies its execution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
