[
https://issues.apache.org/jira/browse/BEAM-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153055#comment-16153055
]
ASF GitHub Bot commented on BEAM-1763:
--------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/beam/pull/3807
[BEAM-1763] Ensure run waitUntilFinish in TestPipeline.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam test-pipeline
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3807
----
commit 0ffd66ad3e158f0a7b6893a82305c41ff55d1da7
Author: Pei He <[email protected]>
Date: 2017-08-30T05:12:22Z
[BEAM-1763] Ensure runners run waitUntilFinish in TestPipeline.
----
> TestPipeline should ensure that all assertions succeeded
> --------------------------------------------------------
>
> Key: BEAM-1763
> URL: https://issues.apache.org/jira/browse/BEAM-1763
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Aviem Zur
> Fix For: 2.0.0
>
>
> This doesn't need to be part of each {{PipelineRunner}} implementation if it
> goes through the {{PipelineResult}} APIs. The assertion can be of the form
> that if the Pipeline is finished, then the number of successful assertions is
> equal to the total number of assertions.
> Suggested solution:
> For runners which support metrics, use the counters for successful/failed
> assertions and compare them to expected number of assertions.
> Runners which do not support metrics should either implement metrics or
> override {{PAssert}} in a way that verifies its execution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
