[
https://issues.apache.org/jira/browse/BEAM-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188066#comment-16188066
]
ASF GitHub Bot commented on BEAM-3006:
--------------------------------------
GitHub user urisilberstein opened a pull request:
https://github.com/apache/beam/pull/3929
[BEAM-3006] fixing minor issue in PipelineTest testReplacedNames
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/urisilberstein/beam fixing-replace-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3929.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3929
----
commit ba13ed81fe9ce1d0ae821ca95eac43ff8a178d5a
Author: Uri Silberstein <[email protected]>
Date: 2017-10-02T13:27:13Z
fixing minor in PipelineTest.testReplacedNames
----
> Minor fix in PipelineTest.testReplacedNames()
> ---------------------------------------------
>
> Key: BEAM-3006
> URL: https://issues.apache.org/jira/browse/BEAM-3006
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Reporter: Uri Silberstein
> Assignee: Uri Silberstein
> Priority: Minor
>
> This method tests the pipeline replace functionality.
> It does so by replacing a OriginalTransform with ReplacementTransform and
> then assert that the pipeline contains the ReplacementTransform by assert the
> transformation name.
> The problem is that both transformations (OriginalTransform and
> ReplacementTransform) have the same transformation name. So the assert
> doesn't really checks a thing
> The offered fix:
> Changing the names to "original_name" and "replacement_name" respectively and
> then asserting that transformation name is "replacement_name" and not
> "original_name"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
