[
https://issues.apache.org/jira/browse/BEAM-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209684#comment-16209684
]
ASF GitHub Bot commented on BEAM-3006:
--------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3929
> Minor fix in PipelineTest.testReplacedNames()
> ---------------------------------------------
>
> Key: BEAM-3006
> URL: https://issues.apache.org/jira/browse/BEAM-3006
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Reporter: Uri Silberstein
> Assignee: Uri Silberstein
> Priority: Minor
>
> This method tests the pipeline replace functionality.
> It does so by replacing a OriginalTransform with ReplacementTransform and
> then assert that the pipeline contains the ReplacementTransform by assert the
> transformation name.
> The problem is that both transformations (OriginalTransform and
> ReplacementTransform) have the same transformation name. So the assert
> doesn't really checks a thing
> The offered fix:
> Changing the names to "original_name" and "replacement_name" respectively and
> then asserting that transformation name is "replacement_name" and not
> "original_name"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
