[
https://issues.apache.org/jira/browse/BEAM-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219124#comment-16219124
]
ASF GitHub Bot commented on BEAM-3081:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/4037
[BEAM-3081] NonNull by default for sdk/transforms and friends
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @jkff
Also fixes a couple things masked by Jenkins outage. I expect current
precommit job to yield real signal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam NonNull-up-to-transforms
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4037
----
commit 6221eb7646925d8a453c98c786dab5a689107fe9
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-22T02:42:33Z
NonNull by default in sdk/transforms
commit b9b1454e24efcddac379955dccf24f730ed27269
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-24T02:17:00Z
NonNull by default in sdk/transforms/windowing
commit 17f445118915ddc9eeea03fe91c952b52e6dcce8
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-24T02:23:41Z
NonNull by default in sdk/transforms/reflect
commit e0614ad81e13ad0688ffbbd9183fd4907c51383e
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-24T02:32:02Z
NonNull by default in sdk/transforms/display
commit 88e14a2d05a1f99e08ac9a597a02cb3000d88e4c
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-24T02:35:08Z
NonNull by default in sdk/transforms/join
commit 03af7c16a0ab3a71fe35b811a0aa56a3821fa261
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-25T16:38:55Z
Fix nullability of ReadableStates.immediate
commit 8b6f940beb1dae84b06b0b335f57bf135293ea4a
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-25T16:39:20Z
Fix nullability in TransformHierarchy
commit f78441e0f4b7b2533b3ac930f7f6ef0b4da114b5
Author: Kenneth Knowles <[email protected]>
Date: 2017-10-25T16:58:40Z
Fix nullability in GearpumpPipelineResult
----
> Our findbugs config does not actually use Nullable annotations effectively
> --------------------------------------------------------------------------
>
> Key: BEAM-3081
> URL: https://issues.apache.org/jira/browse/BEAM-3081
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> We use {{@Nullable}} annotations mostly appropriately, but in fact our
> findbugs config was not delivering value based on these annotations, because
> it does not default to {{@NonNull}}. We can and should set this default.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
