[
https://issues.apache.org/jira/browse/BEAM-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219289#comment-16219289
]
Luke Cwik commented on BEAM-3081:
---------------------------------
Still getting failures in org.apache.beam.runners.apex.ApexRunnerResult
Example run:
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/15327
Relevant build logs:
2017-10-25T17:53:29.740 [INFO] --- findbugs-maven-plugin:3.0.4:check (default)
@ beam-runners-apex ---
2017-10-25T17:53:29.760 [INFO] BugInstance size is 2
2017-10-25T17:53:29.761 [INFO] Error size is 0
2017-10-25T17:53:29.768 [INFO] Total bugs: 2
2017-10-25T17:53:29.785 [INFO] Null passed for non-null parameter of
waitUntilFinish(Duration) in
org.apache.beam.runners.apex.ApexRunnerResult.waitUntilFinish()
[org.apache.beam.runners.apex.ApexRunnerResult] At ApexRunnerResult.java:[line
73] NP_NONNULL_PARAM_VIOLATION
2017-10-25T17:53:29.785 [INFO]
org.apache.beam.runners.apex.ApexRunnerResult.waitUntilFinish(Duration) may
return null, but is declared @Nonnull
[org.apache.beam.runners.apex.ApexRunnerResult,
org.apache.beam.runners.apex.ApexRunnerResult] Returned at
ApexRunnerResult.java:[line 65]Known null at ApexRunnerResult.java:[line 65]
NP_NONNULL_RETURN_VIOLATION
2017-10-25T17:53:29.786 [INFO]
> Our findbugs config does not actually use Nullable annotations effectively
> --------------------------------------------------------------------------
>
> Key: BEAM-3081
> URL: https://issues.apache.org/jira/browse/BEAM-3081
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> We use {{@Nullable}} annotations mostly appropriately, but in fact our
> findbugs config was not delivering value based on these annotations, because
> it does not default to {{@NonNull}}. We can and should set this default.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
