[
https://issues.apache.org/jira/browse/BEAM-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271653#comment-16271653
]
ASF GitHub Bot commented on BEAM-3174:
--------------------------------------
charlesccychen commented on a change in pull request #4125: [BEAM-3174] If
parse_version just gives us a regular tuple use that for formatting
URL: https://github.com/apache/beam/pull/4125#discussion_r153933197
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/dependency.py
##########
@@ -547,8 +547,12 @@ def _get_required_container_version(job_type=None):
version = pkg_resources.get_distribution(GOOGLE_PACKAGE_NAME).version
# We drop any pre/post parts of the version and we keep only the X.Y.Z
# format. For instance the 0.3.0rc2 SDK version translates into 0.3.0.
- container_version = (
- '%s.%s.%s' % pkg_resources.parse_version(version)._version.release)
+ parsed_version = pkg_resources.parse_version(version)
Review comment:
I think we should prefer using specifying a >= version for setuptools, if
possible, instead of continuing to maintain workarounds like these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Master python sdk seems broken with
> test_harness_override_present_in_dataflow_distributions on Py 2.7.6
> -------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3174
> URL: https://issues.apache.org/jira/browse/BEAM-3174
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: holdenk
> Assignee: Ahmet Altay
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
