[
https://issues.apache.org/jira/browse/BEAM-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273236#comment-16273236
]
ASF GitHub Bot commented on BEAM-3239:
--------------------------------------
aaltay commented on a change in pull request #4178: [BEAM-3239] Adding debug
server to sdk worker to get threaddumps
URL: https://github.com/apache/beam/pull/4178#discussion_r154176128
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker_main.py
##########
@@ -30,6 +31,39 @@
# This module is experimental. No backwards-compatibility guarantees.
+class StatusServer(object):
+
+ def start(self, STATUS_HTTP_PORT=0, started_callback=None):
Review comment:
Can you document the arguments in pydocs?
And why do we need these arguments:
`STATUS_HTTP_PORT` is really constant 0 for now to pick a random port. We
can use a constant instead.
`started_callback` seems like it is just a test construct. Do we need it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable debug server for python sdk workers
> ------------------------------------------
>
> Key: BEAM-3239
> URL: https://issues.apache.org/jira/browse/BEAM-3239
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Minor
>
> Enable status server to dump threads when http get call is made to the server.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
