[
https://issues.apache.org/jira/browse/BEAM-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273234#comment-16273234
]
ASF GitHub Bot commented on BEAM-3239:
--------------------------------------
aaltay commented on a change in pull request #4178: [BEAM-3239] Adding debug
server to sdk worker to get threaddumps
URL: https://github.com/apache/beam/pull/4178#discussion_r154176655
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py
##########
@@ -0,0 +1,75 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+"""Tests for apache_beam.runners.worker.sdk_worker_main."""
+
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+
+import functools
+import httplib
+import logging
+import threading
+import unittest
+
+from apache_beam.runners.worker import sdk_worker_main
+
+
+class SdkWorkerMainTest(unittest.TestCase):
Review comment:
Can we just test that `do_Get` returns what we want, instead of starting a
server and connecting to it? It will still test our code (stack trace
generation). Even though it will not test the server creation, it will simplify
the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable debug server for python sdk workers
> ------------------------------------------
>
> Key: BEAM-3239
> URL: https://issues.apache.org/jira/browse/BEAM-3239
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Minor
>
> Enable status server to dump threads when http get call is made to the server.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
