[
https://issues.apache.org/jira/browse/BEAM-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273325#comment-16273325
]
ASF GitHub Bot commented on BEAM-3243:
--------------------------------------
jkff commented on a change in pull request #4185: BEAM-3243 better error
message when there are conflicting anonymous names
URL: https://github.com/apache/beam/pull/4185#discussion_r154186471
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
##########
@@ -636,4 +649,49 @@ public void visitPrimitiveTransform(Node node) {
node.getTransform().validate(options);
}
}
+
+ private static class TransformToMessage implements Function<PTransform<?,
?>, String> {
+ @Override
+ public String apply(final PTransform<?, ?> transform) {
+ final Object representant;
+ if (ParDo.SingleOutput.class.isInstance(transform)) {
Review comment:
Sorry, I don't understand which internal Beam data you have in mind. Line
664 calls toString() - so all you need to get rid of special-casing ParDo as
opposed to the dozens of other Beam transforms is to add .toString() methods to
ParDo.SingleOutput and MultiOutput, which will be useful for debugging anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> multiple anonymous DoFn lead to conflicting names
> -------------------------------------------------
>
> Key: BEAM-3243
> URL: https://issues.apache.org/jira/browse/BEAM-3243
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Romain Manni-Bucau
> Fix For: 2.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
