[ 
https://issues.apache.org/jira/browse/BEAM-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273506#comment-16273506
 ] 

ASF GitHub Bot commented on BEAM-3243:
--------------------------------------

rmannibucau commented on a change in pull request #4185: BEAM-3243 better error 
message when there are conflicting anonymous names
URL: https://github.com/apache/beam/pull/4185#discussion_r154208726
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
 ##########
 @@ -636,4 +649,49 @@ public void visitPrimitiveTransform(Node node) {
       node.getTransform().validate(options);
     }
   }
+
+  private static class TransformToMessage implements Function<PTransform<?, 
?>, String> {
+    @Override
+    public String apply(final PTransform<?, ?> transform) {
+      final Object representant;
+      if (ParDo.SingleOutput.class.isInstance(transform)) {
 
 Review comment:
   Hmm, not really cause the goal is to log the min info needed for the user to 
fix it. XOutput doesnt help since it is ignored in the name computation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> multiple anonymous DoFn lead to conflicting names
> -------------------------------------------------
>
>                 Key: BEAM-3243
>                 URL: https://issues.apache.org/jira/browse/BEAM-3243
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core
>            Reporter: Romain Manni-Bucau
>            Assignee: Romain Manni-Bucau
>             Fix For: 2.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to