ASF GitHub Bot logged work on BEAM-3841:

                Author: ASF GitHub Bot
            Created on: 13/Mar/18 00:05
            Start Date: 13/Mar/18 00:05
    Worklog Time Spent: 10m 
      Work Description: markflyhigh opened a new pull request #4856: 
[BEAM-3841] Fix TestDataflowRunner.run to run_pipeline
URL: https://github.com/apache/beam/pull/4856
   Since DataflowRunner renamed `run` to `run_pipeline` in 
 same rename should also happen in TestDataflowRunner, whose run function 
overrides DataflowRunner's.
   Test is done by running wordcount_it_test on Dataflow.
   Follow this checklist to help us incorporate your contribution quickly and 
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
    - [ ] Write a pull request description that is detailed enough to 
      - [ ] What the pull request does
      - [ ] Why it does it
      - [ ] How it does it
      - [ ] Why this approach
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

            Worklog Id:     (was: 79667)
            Time Spent: 10m
    Remaining Estimate: 0h

> Python TestDataflowRunner should oeverride run_pipeline
> -------------------------------------------------------
>                 Key: BEAM-3841
>                 URL: https://issues.apache.org/jira/browse/BEAM-3841
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Mark Liu
>            Assignee: Mark Liu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
> [TestDataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py]
>  is inherited from 
> [DataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py].
>  Basically, it wraps DataflowRunner.run_pipeline and provide more test 
> actions. 
> However DataflowRunner.run renamed to run_pipeline in [this 
> commit|https://github.com/apache/beam/commit/8cf222d3db1188aff5432af548961fc670f97635],
>  but run function in TestDataflowRunner didn't change.
> We should change it accordingly.

This message was sent by Atlassian JIRA

Reply via email to