ASF GitHub Bot logged work on BEAM-1251:

                Author: ASF GitHub Bot
            Created on: 13/Mar/18 20:26
            Start Date: 13/Mar/18 20:26
    Worklog Time Spent: 10m 
      Work Description: aaltay closed pull request #4834: [BEAM-1251] Fix 
basestring for Python 3 - again
URL: https://github.com/apache/beam/pull/4834

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/python/apache_beam/io/filesystems.py 
index 642c1cdd2a6..17d8d37a061 100644
--- a/sdks/python/apache_beam/io/filesystems.py
+++ b/sdks/python/apache_beam/io/filesystems.py
@@ -19,6 +19,8 @@
 import re
+from six import string_types
 from apache_beam.io.filesystem import BeamIOError
 from apache_beam.io.filesystem import CompressionTypes
 from apache_beam.io.filesystem import FileSystem
@@ -261,7 +263,7 @@ def delete(paths):
       ``BeamIOError`` if any of the delete operations fail
-    if isinstance(paths, basestring):
+    if isinstance(paths, string_types):
       raise BeamIOError('Delete passed string argument instead of list: %s' %
     if len(paths) == 0:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 80048)
    Time Spent: 6h 50m  (was: 6h 40m)

> Python 3 Support
> ----------------
>                 Key: BEAM-1251
>                 URL: https://issues.apache.org/jira/browse/BEAM-1251
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Eyad Sibai
>            Priority: Trivial
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
> I have been trying to use google datalab with python3. As I see there are 
> several packages that does not support python3 yet which google datalab 
> depends on. This is one of them.
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/6

This message was sent by Atlassian JIRA

Reply via email to