[
https://issues.apache.org/jira/browse/BEAM-1251?focusedWorklogId=82096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82096
]
ASF GitHub Bot logged work on BEAM-1251:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/18 23:44
Start Date: 19/Mar/18 23:44
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #4820: [BEAM-1251] Upgrade
from buffer to memoryview for Python 3
URL: https://github.com/apache/beam/pull/4820#issuecomment-374423323
No, the changed version also does not work. This
`six.binary_type(memoryview(data)[:-4])` results in the literal string of the
form `<memory at 0x7f62ee334510>` and fails with `snappy.UncompressError: Error
while decompressing: invalid input`
Besides binary_type is just str, even if it worked as expected in this case
it would have created a copy of data, which beats the purpose.
The real solution here would be to upgrade snappy to accept memoryview as an
argument. If we cannot do that, we can remove the optimization and settle for
`snappy.decompress(data[:-4])`. Or perhaps better we can conditionally keep the
`buffer` for python2 only.
CC'ing a few people who might have an idea of the impact of copying data
here:
cc: @chamikaramj @katsiapis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82096)
Time Spent: 8h 20m (was: 8h 10m)
> Python 3 Support
> ----------------
>
> Key: BEAM-1251
> URL: https://issues.apache.org/jira/browse/BEAM-1251
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Eyad Sibai
> Priority: Trivial
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> I have been trying to use google datalab with python3. As I see there are
> several packages that does not support python3 yet which google datalab
> depends on. This is one of them.
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/6
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
