[ https://issues.apache.org/jira/browse/BEAM-3702?focusedWorklogId=81299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81299 ]
ASF GitHub Bot logged work on BEAM-3702: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Mar/18 17:56 Start Date: 16/Mar/18 17:56 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #4683: [BEAM-3702] adding fromJvm to create pipelineoptions from the system properties URL: https://github.com/apache/beam/pull/4683#discussion_r175168913 ########## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java ########## @@ -1797,6 +1799,44 @@ public void serialize(JacksonIncompatible jacksonIncompatible, JsonGenerator jso } } + @Test + public void testPipelineOptionsFactoryFromProperties() { + assertEquals("testAppName", PipelineOptionsFactory.fromProperties(new Properties() {{ + put("appName", "testAppName"); + }}).as(ApplicationNameOptions.class).getAppName()); + } + + @Test + public void testPipelineOptionsFactoryFromPropertiesWithPrefix() { + assertEquals( + "testAppName", + PipelineOptionsFactory.fromProperties("prefix.", new Properties() {{ + put("prefix.appName", "testAppName"); Review comment: Add a value which shouldn't be matched and test that it isn't set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 81299) Time Spent: 10h (was: 9h 50m) > Support system properties source for pipeline options > ----------------------------------------------------- > > Key: BEAM-3702 > URL: https://issues.apache.org/jira/browse/BEAM-3702 > Project: Beam > Issue Type: Task > Components: sdk-java-core > Reporter: Romain Manni-Bucau > Assignee: Romain Manni-Bucau > Priority: Major > Fix For: 2.5.0 > > Time Spent: 10h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)