[
https://issues.apache.org/jira/browse/BEAM-3702?focusedWorklogId=81286&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81286
]
ASF GitHub Bot logged work on BEAM-3702:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/18 17:56
Start Date: 16/Mar/18 17:56
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #4683:
[BEAM-3702] adding fromJvm to create pipelineoptions from the system properties
URL: https://github.com/apache/beam/pull/4683#discussion_r175164646
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
##########
@@ -1792,4 +1804,82 @@ private synchronized void register(Class<? extends
PipelineOptions> iface) {
return combinedCache.get(interfaces).getPropertyDescriptors();
}
}
+
+ /**
+ * @param prefix a prefix filter on the map keys.
+ * @param options the options to convert to a pipeline options.
+ * @return a pipeline options instance based on the specified configuration.
+ */
+ @Experimental
+ public static PipelineOptions fromMap(final String prefix, final Map<String,
String> options) {
Review comment:
Why is this important to have part of the API?
It seems like we should ask users to filter their map keys themselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 81286)
Time Spent: 8h 40m (was: 8.5h)
> Support system properties source for pipeline options
> -----------------------------------------------------
>
> Key: BEAM-3702
> URL: https://issues.apache.org/jira/browse/BEAM-3702
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Romain Manni-Bucau
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
