[
https://issues.apache.org/jira/browse/BEAM-3744?focusedWorklogId=82406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82406
]
ASF GitHub Bot logged work on BEAM-3744:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 18:50
Start Date: 20/Mar/18 18:50
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #4901:
[BEAM-3744] Expand Pubsub read API for Python.
URL: https://github.com/apache/beam/pull/4901#discussion_r175883773
##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -44,8 +68,8 @@
pubsub_pb2 = None
-__all__ = ['PubsubMessage', 'ReadMessagesFromPubSub', 'ReadStringsFromPubSub',
- 'WriteStringsToPubSub']
+__all__ = ['PubsubMessage', 'ReadMessagesFromPubSub', 'ReadPayloadsFromPubSub',
Review comment:
Do we need 3 variations of ReadXFromPubSub transform? I would suggest
considering making the underlying _ReadFromPubSub transform public, and letting
users parametrize it to their needs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82406)
Time Spent: 4h (was: 3h 50m)
> Support full PubsubMessages
> ---------------------------
>
> Key: BEAM-3744
> URL: https://issues.apache.org/jira/browse/BEAM-3744
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Critical
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Tracking changes to Pubsub support in Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
