[
https://issues.apache.org/jira/browse/BEAM-3744?focusedWorklogId=82889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82889
]
ASF GitHub Bot logged work on BEAM-3744:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/18 19:53
Start Date: 21/Mar/18 19:53
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #4901:
[BEAM-3744] Expand Pubsub read API for Python.
URL: https://github.com/apache/beam/pull/4901#discussion_r176217418
##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -44,8 +68,8 @@
pubsub_pb2 = None
-__all__ = ['PubsubMessage', 'ReadMessagesFromPubSub', 'ReadStringsFromPubSub',
- 'WriteStringsToPubSub']
+__all__ = ['PubsubMessage', 'ReadMessagesFromPubSub', 'ReadPayloadsFromPubSub',
Review comment:
Thank you for the pointers.
I am trying to build a mental map of API available in both SDKs. You are
proposing:
PTransforms:
- ReadMessagesFromPubSub: Outputs elements of type ``PubsubMessage``.
- ReadPayloadsFromPubSub: Outputs elements of type ``str``.
- ReadStringsFromPubSub: Outputs elements of type ``unicode``, decoded from
UTF-8.
in Java there is
readMessages -> returns elements of type ``PubsubMessage.payload`
readMessagesWithAttributes -> returns both payload and attribute map
readStrings -> returns utf-8 decoded strings
There is also readProtos and readAvros.
Should we standardize on something like:
ReadStringsFromPubSub - strings
ReadMessagesFromPubSub - PubSubMessage (attributes being an argument to
ReadMessagesFromPubSub, depending on that PubSubMessage will have the
attributes or not.)
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82889)
Time Spent: 4h 40m (was: 4.5h)
> Support full PubsubMessages
> ---------------------------
>
> Key: BEAM-3744
> URL: https://issues.apache.org/jira/browse/BEAM-3744
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Critical
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Tracking changes to Pubsub support in Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
