[
https://issues.apache.org/jira/browse/BEAM-3895?focusedWorklogId=82532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82532
]
ASF GitHub Bot logged work on BEAM-3895:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 22:59
Start Date: 20/Mar/18 22:59
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #4910:
[BEAM-3895] Add Side Inputs to ExecutableStage
URL: https://github.com/apache/beam/pull/4910#discussion_r175947778
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/ExecutableStage.java
##########
@@ -139,14 +151,27 @@ default PTransform toPTransform() {
*/
static ExecutableStage fromPayload(ExecutableStagePayload payload,
Components components) {
Environment environment = payload.getEnvironment();
- PCollectionNode input = PipelineNode.pCollection(payload.getInput(),
- components.getPcollectionsOrThrow(payload.getInput()));
- List<PTransformNode> transforms = payload.getTransformsList().stream()
- .map(id -> PipelineNode.pTransform(id,
components.getTransformsOrThrow(id)))
- .collect(Collectors.toList());
- List<PCollectionNode> outputs = payload.getOutputsList().stream()
- .map(id -> PipelineNode.pCollection(id,
components.getPcollectionsOrThrow(id)))
- .collect(Collectors.toList());
- return ImmutableExecutableStage.of(environment, input, transforms,
outputs);
+ PCollectionNode input =
+ PipelineNode.pCollection(
+ payload.getInput(),
components.getPcollectionsOrThrow(payload.getInput()));
Review comment:
At this pointm it may be worth wrapping the getXOrThrow calls to actually
return a legible error message since the generated code does not print the
input ids.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82532)
Time Spent: 50m (was: 40m)
> Side Inputs should be available on ExecutableStage
> --------------------------------------------------
>
> Key: BEAM-3895
> URL: https://issues.apache.org/jira/browse/BEAM-3895
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Doing this ensures that the runner will have the side inputs immediately
> available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
