[
https://issues.apache.org/jira/browse/BEAM-3895?focusedWorklogId=82781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82781
]
ASF GitHub Bot logged work on BEAM-3895:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/18 15:39
Start Date: 21/Mar/18 15:39
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #4910:
[BEAM-3895] Add Side Inputs to ExecutableStage
URL: https://github.com/apache/beam/pull/4910#discussion_r176129420
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/GreedyStageFuserTest.java
##########
@@ -888,6 +888,72 @@ public void materializesWithSideInputConsumer() {
assertThat(subgraph, hasSubtransforms(readNode.getId()));
}
+ @Test
+ public void sideInputIncludedInStage() {
+ Environment env = Environment.newBuilder().setUrl("common").build();
+ PTransform readTransform =
+ PTransform.newBuilder()
+ .putInputs("input", "impulse.out")
+ .putOutputs("output", "read.out")
+ .setSpec(
+ FunctionSpec.newBuilder()
+ .setUrn(PTransformTranslation.PAR_DO_TRANSFORM_URN)
+ .setPayload(
+ ParDoPayload.newBuilder()
+
.setDoFn(SdkFunctionSpec.newBuilder().setEnvironmentId("common"))
+ .build()
+ .toByteString()))
+ .build();
+
+ PTransform parDoTransform =
+ PTransform.newBuilder()
+ .putInputs("input", "read.out")
+ .putInputs("side_input", "side_read.out")
+ .putOutputs("output", "parDo.out")
+ .setSpec(
+ FunctionSpec.newBuilder()
+ .setUrn(PTransformTranslation.PAR_DO_TRANSFORM_URN)
+ .setPayload(
+ ParDoPayload.newBuilder()
+
.setDoFn(SdkFunctionSpec.newBuilder().setEnvironmentId("common"))
+ .putSideInputs("side_input",
SideInput.getDefaultInstance())
+ .build()
+ .toByteString()))
+ .build();
+ PCollection sideInputPCollection =
+ PCollection.newBuilder().setUniqueName("side_read.out").build();
+ QueryablePipeline p =
+ QueryablePipeline.forPrimitivesIn(
+ partialComponents
+ .toBuilder()
+ .putTransforms("read", readTransform)
+ .putPcollections(
+ "read.out",
PCollection.newBuilder().setUniqueName("read.out").build())
+ .putTransforms(
+ "side_read",
+ PTransform.newBuilder()
+ .putInputs("input", "impulse.out")
+ .putOutputs("output", "side_read.out")
+ .build())
+ .putPcollections("side_read.out", sideInputPCollection)
+ .putTransforms("parDo", parDoTransform)
+ .putPcollections(
+ "parDo.out",
PCollection.newBuilder().setUniqueName("parDo.out").build())
+ .putEnvironments("common", env)
+ .build());
+
+ PCollectionNode readOutput =
+ getOnlyElement(p.getOutputPCollections(PipelineNode.pTransform("read",
readTransform)));
+ ExecutableStage subgraph =
+ GreedyStageFuser.forGrpcPortRead(
+ p, readOutput, ImmutableSet.of(PipelineNode.pTransform("parDo",
parDoTransform)));
+ System.out.println(subgraph);
Review comment:
remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82781)
Time Spent: 1.5h (was: 1h 20m)
> Side Inputs should be available on ExecutableStage
> --------------------------------------------------
>
> Key: BEAM-3895
> URL: https://issues.apache.org/jira/browse/BEAM-3895
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Doing this ensures that the runner will have the side inputs immediately
> available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
