[
https://issues.apache.org/jira/browse/BEAM-3706?focusedWorklogId=82897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82897
]
ASF GitHub Bot logged work on BEAM-3706:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/18 20:34
Start Date: 21/Mar/18 20:34
Worklog Time Spent: 10m
Work Description: youngoli opened a new pull request #4924: [BEAM-3706]
Removing side inputs from CombinePayload proto.
URL: https://github.com/apache/beam/pull/4924
I'm changing the portable model for Combines to one without side inputs
(details
[here](https://docs.google.com/document/d/1-3mEs3Y7bIkJ0hmQ6SiHpVIFu5vbY6Zcpw-7tOMVg4U/edit?usp=sharing)).
Also without Parameters, but that doesn't seem to be used at all, so not much
of a change there.
In order to have the model continue working without the side inputs I made
these changes:
- Removed all mention of side inputs from CombinePayload and added checks so
that to-proto translation of Combines with side inputs won't work.
- Changed CombineTranslation.translate to return an empty FunctionSpec
instead if the Combine has side inputs. This means combines with side inputs
are now passed to the runner as unknown composite transforms. (Note that this
differs from the doc which mentions completely removing the composite from side
input combines. This approach is much easier with the current code, and the
focus of this PR is getting side inputs out of CombinePayload, so the rest will
be done in other PRs.)
- CombineTranslation.getSideInputs was completely removed, so some changes
were made to the Flink runner to adjust for the fact that Combines will no
longer have side inputs. The changes made there were very simple since it was
intended just to have things compile with the change, so some refactoring
should probably be done there in the future.
- Finally, updated the CombineTranslation tests to account for these changes
by making sure the existing tests don't use side inputs and adding a new test
to ensure that side inputs fail in the to-proto translation.
I ran tests and validation for Java, but wasn't getting the Python tests and
validation to work. A cursory look at Python didn't see any mention of side
inputs along with CombinePayload, so I'm crossing my fingers.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand:
- [x] What the pull request does
- [x] Why it does it
- [x] How it does it
- [x] Why this approach
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82897)
Time Spent: 10m
Remaining Estimate: 0h
> Update CombinePayload to improved model for Portability
> -------------------------------------------------------
>
> Key: BEAM-3706
> URL: https://issues.apache.org/jira/browse/BEAM-3706
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Labels: portability
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This will mean changing the proto definition in beam_runner_api, most likely
> trimming out fields that are no longer necessary and adding any new ones that
> could be useful. The majority of work will probably be in investigating if
> some existing fields can actually be removed (SideInputs and Parameters for
> example).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
