[
https://issues.apache.org/jira/browse/BEAM-3706?focusedWorklogId=83790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83790
]
ASF GitHub Bot logged work on BEAM-3706:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/18 20:11
Start Date: 23/Mar/18 20:11
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #4924:
[BEAM-3706] Removing side inputs from CombinePayload proto.
URL: https://github.com/apache/beam/pull/4924#discussion_r176851219
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
##########
@@ -396,12 +396,8 @@ public void translateNode(
// construct a map from side input to WindowingStrategy so that
// the DoFn runner can map main-input windows to side input windows
Map<PCollectionView<?>, WindowingStrategy<?, ?>> sideInputStrategies =
new HashMap<>();
- List<PCollectionView<?>> sideInputs;
- try {
- sideInputs =
CombineTranslation.getSideInputs(context.getCurrentTransform());
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
+ List<PCollectionView<?>> sideInputs = new ArrayList<>();
Review comment:
Since we no longer have side inputs in Combine, can you go ahead and remove
all references to side inputs in this function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 83790)
Time Spent: 1h 20m (was: 1h 10m)
> Update CombinePayload to improved model for Portability
> -------------------------------------------------------
>
> Key: BEAM-3706
> URL: https://issues.apache.org/jira/browse/BEAM-3706
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Labels: portability
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This will mean changing the proto definition in beam_runner_api, most likely
> trimming out fields that are no longer necessary and adding any new ones that
> could be useful. The majority of work will probably be in investigating if
> some existing fields can actually be removed (SideInputs and Parameters for
> example).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
