[
https://issues.apache.org/jira/browse/BEAM-3738?focusedWorklogId=83062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83062
]
ASF GitHub Bot logged work on BEAM-3738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/18 04:26
Start Date: 22/Mar/18 04:26
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #4877:
[BEAM-3738] Enable py3 lint and cleanup tox.ini.
URL: https://github.com/apache/beam/pull/4877#discussion_r176305503
##########
File path: sdks/python/tox.ini
##########
@@ -27,44 +28,78 @@ select = E3
# Shared environment options.
[testenv]
-# Set [] options for pip install, e.g., pip install apache-beam[test].
+# Set [] options for pip installation of apache-beam tarball.
extras = test
-# Always recreate the virtual environment.
-recreate = True
-# Pass these environment variables to the test environment.
-passenv = TRAVIS*
# Don't warn that these commands aren't installed.
whitelist_externals =
find
time
[testenv:py27]
commands =
+ python --version
+ pip --version
{toxinidir}/run_tox_cleanup.sh
python apache_beam/examples/complete/autocomplete_test.py
- python setup.py test
+ #python setup.py test
{toxinidir}/run_tox_cleanup.sh
[testenv:py27-cython]
+deps =
+ nose==1.3.7
+ grpcio-tools==1.3.5
+ cython==0.25.2
+commands =
+ python --version
+ pip --version
+ time {toxinidir}/run_pylint.sh
+
+[testenv:py27-cython2]
+# cython tests are only expected to work in linux (2.x and 3.x)
+# If we want to add other platforms in the future, it should be:
+# `platform = linux2|darwin|...`
+# See https://docs.python.org/2/library/sys.html#sys.platform for platform
codes
+platform = linux2
+deps =
+ nose==1.3.7
+ grpcio-tools==1.3.5
+ cython==0.25.2
+commands =
+ python --version
+ pip --version
+ {toxinidir}/run_tox_cleanup.sh
+ python apache_beam/examples/complete/autocomplete_test.py
+ #python setup.py test
+ {toxinidir}/run_tox_cleanup.sh
+# TODO: remove if unneeded
+passenv = TRAVIS*
+
+[testenv:py27-cython3]
# cython tests are only expected to work in linux (2.x and 3.x)
# If we want to add other platforms in the future, it should be:
# `platform = linux2|darwin|...`
# See https://docs.python.org/2/library/sys.html#sys.platform for platform
codes
platform = linux2
deps =
- cython==0.26.1
+ cython==0.25.2
commands =
+ python --version
+ pip --version
{toxinidir}/run_tox_cleanup.sh
python apache_beam/examples/complete/autocomplete_test.py
- python setup.py test
+ #python setup.py test
{toxinidir}/run_tox_cleanup.sh
+# TODO: remove if unneeded
+passenv = TRAVIS*
[testenv:py27-gcp]
extras = test,gcp
commands =
+ python --version
+ pip --version
{toxinidir}/run_tox_cleanup.sh
python apache_beam/examples/complete/autocomplete_test.py
- python setup.py test
+ #python setup.py test
Review comment:
left over?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 83062)
Time Spent: 8h (was: 7h 50m)
> Enable Py3 linting in Jenkins
> -----------------------------
>
> Key: BEAM-3738
> URL: https://issues.apache.org/jira/browse/BEAM-3738
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: holdenk
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 8h
> Remaining Estimate: 0h
>
> After BEAM-3671 is finished enable linting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
